Why does Play's "runPlayBinary" always load "twice"?


(Yiming Wang`) #1

We found that since Gradle 4.2 runPlayBinary always loads twice in the first run

such as

[info] p.c.s.AkkaHttpServer - Listening for HTTP on /0:0:0:0:0:0:0:0:9000
 
> Task :runPlayBinary
Running Play App (:runPlayBinary) at http://localhost:9000/
 
BUILD SUCCESSFUL in 54s
7 actionable tasks: 7 executed
 
Reloadable deployment detected. Entering continuous build.
 
BUILD SUCCESSFUL in 54s
7 actionable tasks: 1 executed, 6 up-to-date
 
Waiting for changes to input files of tasks... (ctrl-d to exit)

Why is it running twice? Should it just run once?


(Bo Zhang) #3

Thanks for reporting @ymwang1984 . Sorry for the delay. Interestingly, if you run ./gradlew runPlayBinary -t with -t (or --continuous), the build will run only once.

The first build runs the real build (compile/assemble/start server), if Gradle finds there’s any “deployment” running after the first build finishes, it will enter continuous build mode automatically - the second build.

I don’t know why we made this change in 4.2, but this does look like an expected behaviour. I’d say this doesn’t look good, and I’d like to see only one build in this scenario.

I want to make sure if this does any harm to you? Or it’s just annoying?

@daz maybe you can explain it a little bit more.


#4

As described in the PR, this change was done to support a workflow desired by Play developers. Instead of triggering a rebuild of the app on every single change, we wait until an HTTP request is made before rebuilding.

The fact that we execute the build twice on initial startup is a bug. But any fix will need to retain the “build on demand” functionality introduced in #2830.


(Bo Zhang) #5

Thanks @daz for the confirmation.


(Yiming Wang`) #6

Thanks for confirmation. Can we fix this behavior? The user experience is not great with duplicate runs and it also slows down the build.

Another thing is that can we have a mode of “runPlayBinary” to NOT have hot reload?

Before Gradle 4.2, “runPlayBinary” (without “-t”) is the mode without reload. In our company’s CI environment, somehow we have very low file watcher limit for better stability, and that breaks “runPlayBinary” (since it requires high file watcher when the code base is large).


(Yiming Wang`) #7

Submitted issue: https://github.com/gradle/gradle/issues/6789