FileNotFoundException is thrown when I use Japanese letters in java class name

issue-acknowledged
gradle-3421

(Masanori Matsumoto) #1

I am trying to migrate from maven to gradle, but some test classes failed to generate XML test results.

It says ‘Could not write XML test results for com.cybozu.sample.SampleTest$内部のクラス名_ファイル名が長すぎるとテスト結果のxmlファイルの生成に失敗することを確認するためのテスト to file /home/matsu/idea/sample/build/test-results/TEST-com.cybozu.sample.SampleTest$#5185#90e8#306e#30af#30e9#30b9#540d_#30d5#30a1#30a4#30eb#540d#304c#9577#3059#304e#308b#3068#30c6#30b9#30c8#7d50#679c#306e#ff58#ff4d#ff4c#30d5#30a1#30a4#30eb#306e#751f#6210#306b#5931#6557#3059#308b#3053#3068#3092#78ba#8a8d#3059#308b#305f#3081#306e#30c6#30b9#30c8.xml.’

This is because the xml filename becomes longer than 255 letters and exceeds filesystem limit, and I think Gradle should prevent filenames gets too long.

I attached full stacktrace:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> Could not write XML test results for com.cybozu.sample.SampleTest$内部のクラス名_ファイル名が長すぎるとテスト結果のxmlファイルの生成に失敗することを確認するためのテスト to file /home/matsu/idea/sample/build/test-results/TEST-com.cybozu.sample.SampleTest$#5185#90e8#306e#30af#30e9#30b9#540d_#30d5#30a1#30a4#30eb#540d#304c#9577#3059#304e#308b#3068#30c6#30b9#30c8#7d50#679c#306e#ff58#ff4d#ff4c#30d5#30a1#30a4#30eb#306e#751f#6210#306b#5931#6557#3059#308b#3053#3068#3092#78ba#8a8d#3059#308b#305f#3081#306e#30c6#30b9#30c8.xml.

* Try:
Run with --info or --debug option to get more log output.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':test'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:64)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:52)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:53)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:203)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:185)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:66)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:50)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:25)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:110)
	at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
	at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
	at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
	at org.gradle.initialization.DefaultGradleLauncher$4.run(DefaultGradleLauncher.java:154)
	at org.gradle.internal.Factories$1.create(Factories.java:22)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
	at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:151)
	at org.gradle.initialization.DefaultGradleLauncher.access$200(DefaultGradleLauncher.java:32)
	at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:99)
	at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:93)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:62)
	at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:93)
	at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:82)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter$DefaultBuildController.run(InProcessBuildActionExecuter.java:94)
	at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
	at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:43)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:28)
	at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:78)
	at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:48)
	at org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:51)
	at org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:28)
	at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:43)
	at org.gradle.internal.Actions$RunnableActionAdapter.execute(Actions.java:170)
	at org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:237)
	at org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:210)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:35)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:24)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:206)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:169)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:33)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:22)
	at org.gradle.launcher.Main.doAction(Main.java:33)
	at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:54)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:35)
	at org.gradle.launcher.GradleMain.main(GradleMain.java:23)
	at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:30)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:127)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Caused by: org.gradle.api.GradleException: Could not write XML test results for com.cybozu.sample.SampleTest$内部のクラス名_ファイル名が長すぎるとテスト結果のxmlファイルの生成に失敗することを確認するためのテスト to file /home/matsu/idea/sample/build/test-results/TEST-com.cybozu.sample.SampleTest$#5185#90e8#306e#30af#30e9#30b9#540d_#30d5#30a1#30a4#30eb#540d#304c#9577#3059#304e#308b#3068#30c6#30b9#30c8#7d50#679c#306e#ff58#ff4d#ff4c#30d5#30a1#30a4#30eb#306e#751f#6210#306b#5931#6557#3059#308b#3053#3068#3092#78ba#8a8d#3059#308b#305f#3081#306e#30c6#30b9#30c8.xml.
	at org.gradle.api.internal.tasks.testing.junit.result.Binary2JUnitXmlReportGenerator$1.execute(Binary2JUnitXmlReportGenerator.java:58)
	at org.gradle.api.internal.tasks.testing.junit.result.Binary2JUnitXmlReportGenerator$1.execute(Binary2JUnitXmlReportGenerator.java:49)
	at org.gradle.api.internal.tasks.testing.junit.result.InMemoryTestResultsProvider.visitClasses(InMemoryTestResultsProvider.java:52)
	at org.gradle.api.internal.tasks.testing.junit.result.Binary2JUnitXmlReportGenerator.generate(Binary2JUnitXmlReportGenerator.java:49)
	at org.gradle.api.tasks.testing.Test.executeTests(Test.java:554)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:75)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.doExecute(AnnotationProcessingTaskFactory.java:227)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:220)
	at org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:209)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:585)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:568)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:80)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:61)
	... 60 more
Caused by: java.io.FileNotFoundException: /home/matsu/idea/sample/build/test-results/TEST-com.cybozu.sample.SampleTest$#5185#90e8#306e#30af#30e9#30b9#540d_#30d5#30a1#30a4#30eb#540d#304c#9577#3059#304e#308b#3068#30c6#30b9#30c8#7d50#679c#306e#ff58#ff4d#ff4c#30d5#30a1#30a4#30eb#306e#751f#6210#306b#5931#6557#3059#308b#3053#3068#3092#78ba#8a8d#3059#308b#305f#3081#306e#30c6#30b9#30c8.xml (ファイル名が長すぎます)
	at org.gradle.api.internal.tasks.testing.junit.result.Binary2JUnitXmlReportGenerator$1.execute(Binary2JUnitXmlReportGenerator.java:54)
	... 72 more


BUILD FAILED

(Masanori Matsumoto) #2

I copied maven-surefire-plugin code, and patched gradle. it worked well.

diff --git a/subprojects/base-services/src/main/java/org/gradle/internal/FileUtils.java b/subprojects/base-services/src/main/java/org/gradle/internal/FileUtils.java
index 1bb4cb7..570f477 100644
--- a/subprojects/base-services/src/main/java/org/gradle/internal/FileUtils.java
+++ b/subprojects/base-services/src/main/java/org/gradle/internal/FileUtils.java
@@ -27,27 +27,30 @@ import java.util.List;
 public class FileUtils {
     public static final int WINDOWS_PATH_LIMIT = 260;
 
+    private static String getOSSpecificIllegalChars()
+    {
+        if ( System.getProperty( "os.name" ).toLowerCase().startsWith( "win" ) )
+        {
+            return "\\/:*?\"<>|\0";
+        }
+        else
+        {
+            return "/\0";
+        }
+    }
+
     /**
      * Converts a string into a string that is safe to use as a file name. The result will only include ascii characters and numbers, and the "-","_", #, $ and "." characters.
      */
     public static String toSafeFileName(String name) {
-        int size = name.length();
-        StringBuffer rc = new StringBuffer(size * 2);
-        for (int i = 0; i < size; i++) {
-            char c = name.charAt(i);
-            boolean valid = c >= 'a' && c <= 'z';
-            valid = valid || (c >= 'A' && c <= 'Z');
-            valid = valid || (c >= '0' && c <= '9');
-            valid = valid || (c == '_') || (c == '-') || (c == '.') || (c == '$');
-            if (valid) {
-                rc.append(c);
-            } else {
-                // Encode the character using hex notation
-                rc.append('#');
-                rc.append(Integer.toHexString(c));
-            }
+        String result = name;
+        String illegalChars = getOSSpecificIllegalChars();
+        for ( int i = 0; i < illegalChars.length(); i++ )
+        {
+            result = result.replace( illegalChars.charAt( i ), '_' );
         }
-        return rc.toString();
+
+        return result;
     }
 
     public static File assertInWindowsPathLengthLimitation(File file) {

(Benjamin Muschko) #3

It might be worth to send us a pull request to get your work into the Gradle code base. Then you don’t have to maintain your own fork of Gradle anymore.


(Masanori Matsumoto) #4

I send pull request, but it is discarded. What is the solution for the problem.


(Stefan Wolf) #5

For reference, the PR was https://github.com/gradle/gradle/pull/601 .