Using isJava8Compatible() fails with java 9

rjernst · November 12, 2015, 8:51am

Calling any of the “isJavaXCompatible” methods will fail on java 9. This can be traced to the commons-lang call used to do the comparison. It was fixed in commons-lang 3.4, but it looks like gradle 2.8 uses commons-lang 2.6.

https://issues.apache.org/jira/browse/LANG-1027

sterling · November 12, 2015, 11:24pm

Are you seeing the failure coming out of a plugin? We don’t use commons-lang for that comparison:

github.com

gradle/gradle/blob/master/subprojects/base-services/src/main/java/org/gradle/api/JavaVersion.java

/*
 * Copyright 2009 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.gradle.api;

import com.google.common.annotations.VisibleForTesting;

import java.util.regex.Matcher;

This file has been truncated. show original

rjernst · November 12, 2015, 11:40pm

Yeah, it came from the nebula ospackage plugin.

Caused by: java.lang.NullPointerException
at org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast(SystemUtils.java:1371)
at org.apache.commons.lang3.SystemUtils$isJavaVersionAtLeast.call(Unknown Source)
at com.netflix.gradle.plugins.deb.filevisitor.DebFileVisitorStrategyFactory.getStrategy(DebFileVisitorStrategyFactory.groovy:18)

rjernst · November 12, 2015, 11:49pm

Sorry, I hadn’t noticed the netflix part of the stacktrace before. But is it not correct that gradle plugins cannot have divergent dependency versions with those gradle pulls in?

https://issues.gradle.org/browse/GRADLE-1715

sterling · November 12, 2015, 11:50pm

Ah, thanks!

It looks like they’ve fixed that, but it hasn’t been released yet: https://github.com/nebula-plugins/gradle-ospackage-plugin/commit/300349ab598ece152ea7e382c5323b3c168d2bef

sterling · November 12, 2015, 11:51pm

Yes, that’s one of the limitations with the way we load plugin classloaders. It seems like we barely use the commons-lang dependency, so we might be able to just remove it.