Signing required flag not evaluated correctly?


(Benjamin Muschko) #1

I was playing around with the required flag of the signing plugin. When assigning the boolean value false or a closure returning false the task signArchives still gets executed. My understanding was that the task should be skipped if required = false. Am I missing something? GRADLE-2091 is marked as resolved so I assume it’s not a bug at this moment.

apply plugin: 'groovy'
apply plugin: 'signing'
  signing {
    required = false
    sign configurations.archives
}
  task wrapper(type: Wrapper) {
    gradleVersion = '1.0'
}
Ben@Blizzard:~/dev/projects/gradle-tests/signing$ ./gradlew clean build
:clean
:compileJava UP-TO-DATE
:compileGroovy UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar
:signArchives
:assemble
:compileTestJava UP-TO-DATE
:compileTestGroovy UP-TO-DATE
:processTestResources UP-TO-DATE
:testClasses UP-TO-DATE
:test
:check
:build

Signing and Required fail
(Luke Daley) #2

It doesn’t enable/disable. If signing can be done, it will always be done. However, if required = false and signing can’t be performed it will be skipped.


(Benjamin Muschko) #3

Thanks for clarifying that. That wasn’t completely clear to me.


(Luke Daley) #4

Pull requests for documentation improvements always welcome :slight_smile: