org.gradle.integtests.fixtures.AvailableJavaHomes missing null checks for listFiles() calls


(spencer_allain) #1

This test fixture class does not check for the null array that will be returned when the assumed directories do not actually exist.

Happens to me under windows since C:/Program Files/Java doesn’t exist - which could also actually be C:/Program Files (x86)/Java for a 32-bit JVM under a 64-bit windows OS, but it doesn’t check for that right now.

org.gradle.integtest.environment.BuildEnvironmentIntegrationTest will evidence the problem with the assumed directories missing.

Simply missing the isDirectory() test of the other two flavors of OSes (macosx and unix).

Submitted a pull request on my merscwog:build_env_test branch:

https://github.com/merscwog/gradle/tree/build_env_test https://github.com/merscwog/gradle/commit/4437bfff8a8e3597353794e090106aac59d400cf

-Spencer


(Luke Daley) #2

Thanks for the pull request.