Minor testing bug -- gradle unit tests fail if HipChat is running locally

abhishek_mukher_g · August 18, 2016, 2:02am

So the gradle unit tests seem to have:

gradle/gradle/blob/v3.0.0/subprojects/messaging/src/test/groovy/org/gradle/internal/remote/internal/inet/TcpConnectorTest.groovy#L90


    thread.blockUntil.connected


    then:
    1 * action.execute(!null) >> { instant.connected }


    cleanup:
    acceptor?.stop()
    connection?.stop()
}


def "client throws exception when cannot connect to server"() {
    def address = new MultiChoiceAddress(idGenerator.generateId(), 12345, [InetAddress.getByName("localhost")])


    when:
    outgoingConnector.connect(address)


    then:
    ConnectException e = thrown()
    e.message.startsWith "Could not connect to server ${address}."
    e.cause instanceof java.net.ConnectException
}

which, I assume translates to “make sure an error is thrown when connecting to localhost:12345”. wellll:

[amukherjee@chocobo ~/dev/tr/gradle]% ss -tlnp sport = :12345
State       Recv-Q Send-Q                                                            Local Address:Port                                                                           Peer Address:Port              
LISTEN      0      0                                                                     127.0.0.1:12345                                                                                     *:*                   users:(("HipChat.bin",pid=3141,fd=71))

This causes the unit test to fail since something is listening on the port. Specifically, the following two tests fail:

org.gradle.internal.remote.internal.inet.TcpConnectorTest > client throws exception when cannot connect to server FAILED
    org.spockframework.runtime.WrongExceptionThrownError at TcpConnectorTest.groovy:97

org.gradle.internal.remote.internal.inet.TcpConnectorTest > the exception includes last failure when cannot connect FAILED
    org.spockframework.runtime.WrongExceptionThrownError at TcpConnectorTest.groovy:109

Gradle Version: 3.0.0
Operating System: Linux (Arch)

Stefan_Wolf · August 18, 2016, 8:42am

Good catch! I fixed this on Gradle master: https://github.com/gradle/gradle/commit/164f9747122f30ed80e6840441034e4691be5e39